fix(bat): let BatFlags override default style - #1540
Open
pfeifferj wants to merge 1 commit into
Open
Conversation
paru prepended -pp (alias for --style=plain --paging=never) to every bat invocation before user BatFlags. bat's -p wins over a later --style=X regardless of order, so user --style overrides were silently dropped. Replace -pp with the explicit pair so a later --style= in BatFlags can override --style=plain while paging stays off. Signed-off-by: Josephine Pfeiffer <hi@josie.lol>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this change replaces
-ppwith the explicit pair--paging=never --style=plainso a later--style=fromBatFlagscan override--style=plainwhile paging stays offreported in #1539. the BatFlags override contract has been mentioned back in #143 (
--batflags --paging=always), #77 (--batflags --theme=Dracula), #500 ("Set BatFlags"). d36cbe8 ("bat: disable pager") introduced-pppurely to disable bat's pager; the--style=plainside effect of the shorthand does seem to be an intentional lock-in