Conversation
…ccount unlinking logic
…re creating new users
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
Jasonxia007
reviewed
Apr 15, 2026
| username = user_info["username"] | ||
|
|
||
| from utils.auth_utils import get_supabase_admin_client | ||
| from services.oauth_service import get_oauth_account_by_provider |
Contributor
There was a problem hiding this comment.
package import 风格建议统一，放文件头
Jasonxia007
reviewed
Apr 15, 2026
| if not result: | ||
| return False | ||
|
|
||
| session.delete(result) |
Contributor
There was a problem hiding this comment.
当前数据库操作共识中，明确应使用软删除（delete_flag="Y"）移除数据
Jasonxia007
reviewed
Apr 15, 2026
| session.query(UserOAuthAccount) | ||
| .filter( | ||
| UserOAuthAccount.provider == provider, | ||
| UserOAuthAccount.provider_user_id == provider_user_id, |
Contributor
There was a problem hiding this comment.
软删除时需添加delete_flag="Y"的筛选条件
Jasonxia007
reviewed
Apr 15, 2026
|
|
||
| logger = logging.getLogger(__name__) | ||
|
|
||
| _state_store: Dict[str, float] = {} |
Contributor
There was a problem hiding this comment.
全局字典会不会有内存过度膨胀的隐患？先前tenant_config_manager中也用过一回全局字典，结果导致一段时间生产环境nexent-config容器内存爆炸
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.