♻️ Refactor: cleanup model_managment_app.py, memory_config_app.py#1172
Merged
♻️ Refactor: cleanup model_managment_app.py, memory_config_app.py#1172
Conversation
WMC001
reviewed
Sep 10, 2025
WMC001
reviewed
Sep 10, 2025
WMC001
reviewed
Sep 10, 2025
Jasonxia007
force-pushed
the
xyc/backend_refactor2
branch
from
73c3e3c to
0a9dc8e
Compare
porkpink
reviewed
Sep 10, 2025
porkpink
reviewed
Sep 10, 2025
porkpink
reviewed
Sep 10, 2025
Jasonxia007
force-pushed
the
xyc/backend_refactor2
branch
from
0a9dc8e to
3333bcf
Compare
porkpink
reviewed
Sep 10, 2025
porkpink
reviewed
Sep 10, 2025
porkpink
reviewed
Sep 10, 2025
Jasonxia007
force-pushed
the
xyc/backend_refactor2
branch
3 times, most recently
from
d3ca573 to
d517cc4
Compare
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Jasonxia007
force-pushed
the
xyc/backend_refactor2
branch
4 times, most recently
from
8fdd3be to
7f7ece7
Compare
🧪 Update test_model_managment_app.py, test_model_health_service.py 🧪 Update test_model_managment_app.py, test_model_health_service.py
Jasonxia007
force-pushed
the
xyc/backend_refactor2
branch
from
7f7ece7 to
b9d65d4
Compare
Phinease
approved these changes
Sep 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
♻️ Refactor: model_managment_app.py & memory_config_app.py, decouple model_management_service.py
♻️ Remove redundant field declaration in db_models
♻️ Remove os.getenv call in auth_utils which disobey the latest backend standard
🧪 Update test_model_managment_app.py, test_model_health_service.py