Implement ZeroizeOnDrop without Drop#114
Merged
daxpedda merged 3 commits intoModProg:mainfrom May 14, 2025
Merged
Conversation
daxpedda
force-pushed
the
zeroize-on-drop-no-drop
branch
2 times, most recently
from
43ee018 to
e3068c7
Compare
Owner
|
Wondering if we could have the same behavior on field level? Though that could require a better name. |
Collaborator
Author
That is already the default, in |
daxpedda
force-pushed
the
zeroize-on-drop-no-drop
branch
from
e3068c7 to
9d4c919
Compare
ModProg
approved these changes
May 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new option to
ZeroizeOnDrop:no_drop. This will implementZeroizeOnDropwithout implementingDrop. Instead, it will assert that all fields implementZeroizeOnDrop(notZeroize!).The second part of this PR reworks
DeriveTraitand moves the ownership of derive related data to the actualTraitImplinstead of it just being a dummy-struct to implementTraitImplover. Now we have to pass in less parameters to each method and can actually useselfto store data.