Support skipping only some variants with ZeroizeOnDrop#109
Merged
daxpedda merged 1 commit intoModProg:mainfrom Apr 15, 2025
Merged
Support skipping only some variants with ZeroizeOnDrop#109daxpedda merged 1 commit intoModProg:mainfrom
ZeroizeOnDrop#109daxpedda merged 1 commit intoModProg:mainfrom
Conversation
4b5ad2e to
65d6197
Compare
Collaborator
Author
|
I discovered another bug! Apparently the following: #[derive_where(ZeroizeOnDrop)]
enum Test<T> {
A(PhantomData<T>),
#[derive_where(skip_inner)]
B(PhantomData<T>),
}Would generate multiple calls to impl<T> Drop for Test<T> {
fn drop(&mut self) {
Zeroize::zeroize(self);
Zeroize::zeroize(self);
}
} |
ModProg
approved these changes
Apr 15, 2025
65d6197 to
b52e808
Compare
This was referenced Apr 15, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that the following would fail to compile:
Because it produces the following:
Instead, we now make sure to also cover variants that are skipped, but their body is just empty now.
See the test I added for a more complete example.