For Winctrl FCU and PAP 3 do not retrigger on connect #2666
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build for this pull request: |
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes #2382 by preventing Winwing FCU and PAP 3 from implicitly retriggering all button states during initial connection/startup when Auto-retrigger is OFF.
Changes:
- Introduced a separate
DoRetriggerflag to decouple first-report initialization from explicit retrigger behavior. - Updated HID report handling so startup only initializes previous state (no forced edge generation).
- Changed
Retrigger()to setDoRetriggerinstead of reusingDoInitialize.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| MobiFlight/Joysticks/Winwing/WinwingPap3.cs | Separates initial report sync from explicit retrigger logic to avoid startup button retriggers. |
| MobiFlight/Joysticks/Winwing/WinwingFcu.cs | Same separation as PAP3 to prevent unintended retriggering on connect/startup. |
|
Build for this pull request: |
Contributor
Author
|
@DocMoebiuz ready to be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2382 by preventing Winwing FCU and PAP 3 from implicitly retriggering all button states during initial connection/startup when Auto-retrigger is OFF.
Changes: