Use text color for dashboard chevron icons on dark mode #2545
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves the visibility of chevron navigation icons in dark mode by updating their color styling. The chevron icons were previously difficult to see in dark mode, and this change makes them consistent with other navigation elements like the return chevron in the config table view.
- Updated the IconChevronRight styling to use foreground text color in dark mode while maintaining primary color in light mode
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Build for this pull request: |
Collaborator
|
Do they have to be so visible? It is a secondary action for list items. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dark mode chevron icons for navigation are not very visible on dark mode, making them text color so they are easier to see.
Also consistent with config table view's return chevron. Once we have a bit better color design system, the chevrons could have a dash of accent color, but with enough contrast. But for now, text color will ensure it will be usable. I don't want to invent a custom color just for this right now until I have a chance to think the color set through.
before:
after:
