Fix NetworkInformationPreview disposal error#4120
Conversation
|
@copilot move changes to the bottom of the file |
Moved to the bottom of the class in commit |
|
@copilot check failing signals |
…nity 2020.3 compatibility
The CI failure was because |
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #4120 +/- ##
==========================================
- Coverage 42.22% 42.22% -0.01%
==========================================
Files 156 156
Lines 15100 15101 +1
==========================================
Hits 6376 6376
- Misses 8724 8725 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
DOES NOT FIX IT |
Unity logs
"Mirror.NetworkInformationPreview was not disposed properly. Make sure that base.Cleanup is called"becauseObjectPreviewsubclasses must callbase.Cleanup()when disabled.OnDisable() => base.Cleanup()toNetworkInformationPreview