Skip to content

GEOPY-2576: class attribute are forced to be unique if strings: subclass ReferenceValueMap#886

Merged
domfournier merged 1 commit intorelease/GA_4.8from
GEOPY-2576
May 6, 2026
Merged

GEOPY-2576: class attribute are forced to be unique if strings: subclass ReferenceValueMap#886
domfournier merged 1 commit intorelease/GA_4.8from
GEOPY-2576

Conversation

@MatthieuCMira
Copy link
Copy Markdown
Contributor

@MatthieuCMira MatthieuCMira commented May 6, 2026

GEOPY-2576 - class attribute are forced to be unique if strings: subclass ReferenceValueMap
deal with str differently if the data_referenced is the main or not

Copilot AI review requested due to automatic review settings May 6, 2026 15:54
@MatthieuCMira MatthieuCMira changed the base branch from develop to release/GA_4.8 May 6, 2026 15:54
@github-actions github-actions Bot changed the title Geopy 2576 GEOPY-2576: class attribute are forced to be unique if strings: subclass ReferenceValueMap May 6, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.05%. Comparing base (5a3b845) to head (09ccc65).

Additional details and impacted files
@@                Coverage Diff                 @@
##           release/GA_4.8     #886      +/-   ##
==================================================
- Coverage           91.09%   91.05%   -0.05%     
==================================================
  Files                 113      113              
  Lines               10459    10462       +3     
  Branches             1933     1934       +1     
==================================================
- Hits                 9528     9526       -2     
- Misses                493      497       +4     
- Partials              438      439       +1     
Files with missing lines Coverage Δ
geoh5py/data/data_type.py 94.44% <100.00%> (ø)
geoh5py/data/reference_value_map.py 96.77% <100.00%> (+0.16%) ⬆️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@domfournier domfournier merged commit e372d0e into release/GA_4.8 May 6, 2026
21 of 24 checks passed
@domfournier domfournier deleted the GEOPY-2576 branch May 6, 2026 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants