GEOPY-2800: Plate Match: Attach figure with comparative plot of scaled obs versus simulated data#195
Merged
GEOPY-2800: Plate Match: Attach figure with comparative plot of scaled obs versus simulated data#195
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates shared utilities in geoapps_utils by introducing a logging-suppression context manager (with coverage in existing driver tests) and modifying the azimuth calculation in the cartesian_to_polar transformation helper.
Changes:
- Add
suppress_logging()context manager to temporarily disable logging up to a specified level. - Add a test validating that suppressed logs are not captured and that logging is restored afterward.
- Change
cartesian_to_polar()azimuth computation and normalize azimuth to[0, 360).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
geoapps_utils/utils/logger.py |
Adds suppress_logging() context manager for temporarily disabling logging. |
tests/driver_test.py |
Adds test coverage for the new logging suppression behavior. |
geoapps_utils/utils/transformations.py |
Updates azimuth computation/normalization in cartesian_to_polar(). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
benk-mira
previously approved these changes
Apr 20, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #195 +/- ##
===========================================
+ Coverage 85.59% 85.61% +0.02%
===========================================
Files 19 19
Lines 1180 1189 +9
Branches 153 153
===========================================
+ Hits 1010 1018 +8
Misses 129 129
- Partials 41 42 +1
🚀 New features to boost your workflow:
|
benk-mira
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GEOPY-2800 - Plate Match: Attach figure with comparative plot of scaled obs versus simulated data