Skip to content

GEOPY-2800: Plate Match: Attach figure with comparative plot of scaled obs versus simulated data#195

Merged
benk-mira merged 6 commits intodevelopfrom
GEOPY-2800
Apr 20, 2026
Merged

GEOPY-2800: Plate Match: Attach figure with comparative plot of scaled obs versus simulated data#195
benk-mira merged 6 commits intodevelopfrom
GEOPY-2800

Conversation

@domfournier
Copy link
Copy Markdown
Contributor

@domfournier domfournier commented Apr 20, 2026

GEOPY-2800 - Plate Match: Attach figure with comparative plot of scaled obs versus simulated data

@domfournier domfournier marked this pull request as ready for review April 20, 2026 15:54
Copilot AI review requested due to automatic review settings April 20, 2026 15:54
@github-actions github-actions Bot changed the title Geopy 2800 GEOPY-2800: Plate Match: Attach figure with comparative plot of scaled obs versus simulated data Apr 20, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates shared utilities in geoapps_utils by introducing a logging-suppression context manager (with coverage in existing driver tests) and modifying the azimuth calculation in the cartesian_to_polar transformation helper.

Changes:

  • Add suppress_logging() context manager to temporarily disable logging up to a specified level.
  • Add a test validating that suppressed logs are not captured and that logging is restored afterward.
  • Change cartesian_to_polar() azimuth computation and normalize azimuth to [0, 360).

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File Description
geoapps_utils/utils/logger.py Adds suppress_logging() context manager for temporarily disabling logging.
tests/driver_test.py Adds test coverage for the new logging suppression behavior.
geoapps_utils/utils/transformations.py Updates azimuth computation/normalization in cartesian_to_polar().

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread geoapps_utils/utils/transformations.py
Comment thread geoapps_utils/utils/transformations.py
Comment thread tests/driver_test.py Outdated
Comment thread geoapps_utils/utils/logger.py
benk-mira
benk-mira previously approved these changes Apr 20, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.61%. Comparing base (6b26f39) to head (55412d8).
⚠️ Report is 7 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #195      +/-   ##
===========================================
+ Coverage    85.59%   85.61%   +0.02%     
===========================================
  Files           19       19              
  Lines         1180     1189       +9     
  Branches       153      153              
===========================================
+ Hits          1010     1018       +8     
  Misses         129      129              
- Partials        41       42       +1     
Files with missing lines Coverage Δ
geoapps_utils/utils/logger.py 86.66% <100.00%> (+13.93%) ⬆️
geoapps_utils/utils/transformations.py 96.46% <100.00%> (+0.03%) ⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@benk-mira benk-mira merged commit 9baaece into develop Apr 20, 2026
20 checks passed
@benk-mira benk-mira deleted the GEOPY-2800 branch April 20, 2026 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants