Port compatible+develop to mesa - 2026.1.23 #18345
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g up magic config to testnet-generic debian
…inance patch binance archive issue - release/3.3.0
…own when resovling GQL schema
…config.net_config
This change only adds Deferred to the signature of the method that will populate a root ledger from a genesis ledger.
This method works like a checkpoint, but does not throw an exception if the source and destination backings are different. It will instead ensure that the backing at the destination is what is requested, by migrating the primary database at the destination or avoiding checkpointing the migrated database.
The daemon no longer expects that the genesis ledgers have the same backing as the root ledger; if they differ, either the stable genesis ledger database will be copied and migrated at the destination (if the root ledger should have a converting backing), or the migrated genesis ledger database will not be copied (if the root ledger should have a stable backing).
This change lets us avoid keeping migrated genesis ledger databases around on disk. This does require the daemon to migrate these ledgers whenever it wants to bootstrap from genesis, but this operation should be very infrequent (usually happening at most once during startup, and only if the frontier on disk is sufficiently behind the network).
- added --redirect-to-logs option, so output from nodes are not polluting console output
Member
Author
|
!ci-build-me |
[CI] Fix writing to cache
Pickles: document interface of Impl, with some design choice decisions
…ial-snarked-ledgers-compatible Resolve merge conflicts in 18284 - compatible
Member
Author
|
!ci-build-me |
1 similar comment
Member
Author
|
!ci-build-me |
Pickles: document interface of step
…sly migrate_from_berkeley) be identity function, remove bunch of test that doesn't make sense on mesa
glyh
changed the title
Member
|
!ci-build-me |
Member
|
I think we might want some eyes from @cjjdespres on 106423b as I'm removing tests he implemented here. |
Member
|
This PR should be merged after #18352 is merged so to retain the branching rules. |
Member
|
It's interesting to see this PR needs all those reviewers. I thought we don't have a branch protection rule on |
glyh
reviewed
Jan 23, 2026
| } | ||
|
|
||
| (* This function converts Berkeley account to Mesa account *) | ||
| let migrate_from_berkeley ~hardfork_slot (account : Stable.Latest.t) : t = |
Member
There was a problem hiding this comment.
I renamed this to migrate_from_berkeley -> migrate_to_mesa because the original name only make sense if we're working on a berkeley branch.
glyh
reviewed
Jan 23, 2026
| ; permissions = account.permissions | ||
| ; zkapp = Option.map ~f:Zkapp_account.Hardfork.to_stable_exn account.zkapp | ||
| (* This function converts current account to Mesa account *) | ||
| let migrate_to_mesa ~hardfork_slot:_ |
Member
There was a problem hiding this comment.
This is just Fn.id now we've on a mesa branch.
glyh
reviewed
Jan 23, 2026
| type t = Zkapp_basic.F.Stable.V1.t V.t | ||
| [@@deriving sexp, equal, hash, compare, yojson, bin_io_unversioned] | ||
|
|
||
| let of_stable (value : Value.Stable.Latest.t) : t = |
Member
There was a problem hiding this comment.
I don't think these functions matter any more.
Member
Author
|
!ci-build-me |
Member
|
!ci-build-me |
Member
|
Apparantly CI being green here is a false-positive. Don't merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as title