Verifier and snark workers are actually sub-proc #18334
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are run by the main node. Therefore, we suggest to move all the code spawned in other threads in a sub-directory called "services". This would ease the replacement of code that can be rewritten in Rust.
dannywillems
force-pushed
the
dw/services-split
branch
from
a989d9b to
901f11a
Compare
Member
|
We might want to refactor them to not to be services when migrating to OCaml 5 though. Also libp2p helper is a "service". Parts of verifier is running on main process as well. |
Member
Author
We plan to move the verifier from OCaml to Rust, and share this part with the Rust node. |
Member
Author
|
!ci-build-me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are run by the main node.
Therefore, we suggest to move all the code spawned in other threads in a sub-directory called "services". This would ease the replacement of code that can be rewritten in Rust.