Visible queue false#3088
Open
w-e-w wants to merge 2 commits intoMikubill:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found that setting these events to not use gradio's queue works better
more responsive and less likely to desync
this is related to several behaviors such as showing / hideing of the controlnet
Hires-Fix Optiondepending on the state ofHires-Fix checkboxvideo example
before PR with queue
currently desync can happen if the user quickly clicks the
Hires-Fix checkboxmultiple timesin the video I demonstrate double clicking it, and can easily result in the a state that
Hires-Fix checkboxis check but controlnetHires-Fix Optionis hidden vice versa2025-05-03.07_35_06_991.chrome.mp4
with PR queue=False
in video I performing the same action repeatedly double clicking
Hires-Fix checkbox,different from before we can see that the
Hires-Fix checkboxand show/hide state of controlnetHires-Fix Optionis always in sync2025-05-03.06_59_27_023.chrome.mp4
also believe that it is faster and more responsive