Converts project into a Lerna monorepo#83
Open
ctrlplusb wants to merge 5 commits intoMicheleBertoli:masterfrom
Open
Converts project into a Lerna monorepo#83ctrlplusb wants to merge 5 commits intoMicheleBertoli:masterfrom
ctrlplusb wants to merge 5 commits intoMicheleBertoli:masterfrom
Conversation
ctrlplusb
changed the title
ctrlplusb
commented
Nov 14, 2018
| '@babel/plugin-proposal-object-rest-spread', | ||
| 'babel-plugin-idx', | ||
| 'annotate-pure-calls', | ||
| NODE_ENV !== 'test' && [ |
Author
There was a problem hiding this comment.
This plugin was breaking my tests. I don't think it is critical to remove prop-types in tests so I have inserted this condition to avoid the issue.
ctrlplusb
commented
Nov 14, 2018
| { | ||
| "npmClient": "yarn", | ||
| "packages": ["packages/*"], | ||
| "version": "4.0.4", |
Author
There was a problem hiding this comment.
We can change the value for version to "independent" in order to move towards independent version numbers.
ctrlplusb
commented
Nov 14, 2018
| plugins: [babel()], | ||
| }) | ||
|
|
||
| export default [ |
Author
There was a problem hiding this comment.
All 3 packages share the same rollup config. Simples.
Owner
|
This is FANTASTIC, thank you very much @ctrlplusb 💖 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mostly there 👍
What I have done:
react-automata: The core packagereact-automata-test-utilities: Contains the test helperreact-automata-utilities: "Internal" utilities shared between the other packages. May want to consider a rename of this.To be done:
Build is working, and so are the tests. 👍
Note: when performing updates across the packages you may need to perform a build prior to test. It would be cool if there was a mechanism to build on the fly whilst running tests in watch mode.
Closes #32