feat: add KeyringVersion + KeyringCapabilites.versions#439
Closed
feat: add KeyringVersion + KeyringCapabilites.versions#439
KeyringVersion + KeyringCapabilites.versions#439Conversation
hmalik88
approved these changes
Jan 15, 2026
Contributor
Author
|
Closing this one as we might want to couple the new V2 change with a new Snap platform version. The long-term plan would be to incorporate the keyring API support within the platform itself, allowing us to benefit from a global versioning rather than a sub-version only for the keyring part. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding a new
versionsfield in thecapabilities.This way, we will know what keyring API versions is supported and potentially adapt the requests we're sending to that keyring.
Note
Introduces explicit keyring API versioning and updates implementations to declare support.
KeyringVersionenum (V1,V2) and require non-emptyversionsinKeyringCapabilities(keyring-capabilities.ts)hd-keyring-v2.ts,ledger-keyring-v2.ts,simple-keyring-v2.ts,trezor-keyring-v2.ts) to includeversions: [KeyringVersion.V2]versionsin capabilities (keyring-wrapper.test.ts)CHANGELOG.mdWritten by Cursor Bugbot for commit 1cacda0. This will update automatically on new commits. Configure here.