fix findTriTriDistance in case of finite upDistLimitSq#6357
Merged
Conversation
Grantim
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
findTriTriDistancecould return a wrong (overestimated) distance when a non-defaultupDistLimitSqwas given.In the edge-pair loop,
sd.diris the vector between the closest points of the two edges and is not unit length. The projectionsp,s,tare dot products withsd.dir, so they carry an extra factor of|sd.dir|, andsqr( p - s + t )overestimates the actual squared distance between the separating planes by|sd.dir|². This inflated value was compared againstupDistLimitSqand, on early exit, stored inres.distSq— so with a finite limit the function could stop early and report a distance larger than the true one (and larger than what the same call without a limit returns).The fix divides the squared plane distance by
sqr( sd.dir )(guarding against a zero vector), making the early-exit value a true squared distance.Added a regression test with two triangles ~277.5 apart: the distance computed with
upDistLimitSqslightly above the true squared distance must match the unlimited result; before the fix the early exit returned an inflated value.