Add aws-user and github-user to CI docker images, drop --user root#6356
Merged
Conversation
…workflows Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Grantim
reviewed
Jul 2, 2026
| - platform: "x86_64" | ||
| runner: ubuntu-latest | ||
| container-options: "--user root" | ||
| container-options: " " |
Contributor
There was a problem hiding this comment.
do we need this option at all?
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Grantim
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All CI docker images now end with the same two non-root users, and
github-user(UID 1001) is the default:UID 1001 matches the
runneruser on GitHub-hosted runners, so job containers can write to the runner-mounted directories (_runner_file_commands, workspace) without running as root;aws-userkeeps UID 8877 available for self-hosted runners via an explicit--user aws-user.Accordingly,
options: --user rootis removed from all workflows (build-test-ubuntu-x64,build-test-ubuntu-arm64,build-test-linux-vcpkg,generate-c-bindings,update-docs-manual), and thecontainer-optionsmatrix plumbing inpip-buildandrelease-testsis dropped entirely — every container now runs as its image's default user. For the stock distro images used in pip tests this is no behavior change (their default user is already root); MeshLib images now run asgithub-user.Changes for the previously existing users:
ubuntu22/ubuntu24haduser(UID 8877, default): renamed toaws-user, default is nowgithub-user.emscripten/emscripten-build-c-bindingshaduser(UID 1001, default): renamed togithub-user, same UID, so the effective runtime user is unchanged.emscripten-generate-c-bindingsandrockylinux8/9-vcpkghad no user (ran as root, or with--user root): they now default togithub-user.