Add check so unlink button won't show on a new feature - #4685
Open
xkello wants to merge 1 commit into
Open
Conversation
Coverage Report for CI Build 33163588332Coverage remained the same at 59.594%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
馃挍 - Coveralls |
馃摝 Build Artifacts Ready
|
uclaros
reviewed
Aug 28, 2026
|
|
||
| imageSource: __style.negativeMMSymbolImage | ||
| title: qsTr( "Delete photo?" ) | ||
| description: qsTr( "Would you like to delete or unlink the photo? Deleting removes the photo from your project entirely, while unlinking keeps the photo in your project but removes it from this specific feature." ) |
Contributor
There was a problem hiding this comment.
I think this message should also be conditionally changed to "Would you like to delete the photo?" to avoid confusion
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The "Unlink photo" option in the photo delete drawer was showing even when the feature hadn't been saved yet. Since an unsaved feature has no persisted attachment relation to unlink from, the option didn't make sense there.
Fixes: #4542
What changed
Exposed a new
isNewFeatureproperty onAttributeController(reusing the existingfeatureLayerPairChangedsignal so it stays reactive).MMFormPhotoEditorpasses this down asfeatureStatetoMMRemovePhotoDialog, which now hides the "Unlink photo" button whenfeatureState === "add".Behaviour
On a new, unsaved feature, the delete photo drawer now only shows "Delete photo". On an existing, saved feature, both "Delete photo" and "Unlink photo" still show as before.
Desktop:
Android: