Skip to content

Removed the hold and tap behavior of the filtering map button#4456

Open
gabriel-bolbotina wants to merge 3 commits intodev/filteringfrom
filter-modify-filter-chip
Open

Removed the hold and tap behavior of the filtering map button#4456
gabriel-bolbotina wants to merge 3 commits intodev/filteringfrom
filter-modify-filter-chip

Conversation

@gabriel-bolbotina
Copy link
Copy Markdown
Contributor

@gabriel-bolbotina gabriel-bolbotina commented Apr 16, 2026

Renamed the filters enabled member variable to filters activated.
Changed the behaviour of the filter floating button as discussed in this issue
UI:

Enregistrement.de.l.ecran.2026-04-17.a.12.05.30.mov

@gabriel-bolbotina gabriel-bolbotina added enhancement map tools Something is wrong with recording, geometry editing, splitting, stakeout, .. labels Apr 16, 2026
@gabriel-bolbotina gabriel-bolbotina added this to the 2026.2.0 milestone Apr 16, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 16, 2026

Coverage Report for CI Build 24514386312

Warning

No base build found for commit 5222fcf on dev/filtering.
Coverage changes can't be calculated without a base build.
If a base build is processing, this comment will update automatically when it completes.

Coverage: 58.411%

Details

  • Patch coverage: No coverable lines changed in this PR.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

Requires a base build to compare against. How to fix this →


Coverage Stats

Coverage Status
Relevant Lines: 15064
Covered Lines: 8799
Line Coverage: 58.41%
Coverage Strength: 101.25 hits per line

💛 - Coveralls

@github-actions
Copy link
Copy Markdown

📦 Build Artifacts Ready

OS Status Build Info Workflow run
macOS Build Build failed or not found. #6705
linux Build 📬 Mergin Maps 67161 x86_64 Expires: 15/07/2026 #6716
win64 Build 📬 Mergin Maps 59001 win64 Expires: 15/07/2026 #5900
Android Build 📬 Mergin Maps 801711 APK [armeabi-v7a] Expires: 15/07/2026 #8017
📬 Mergin Maps 801711 APK [armeabi-v7a] Google Play Store #8017
Android Build 📬 Mergin Maps 801751 APK [arm64-v8a] Expires: 15/07/2026 #8017
📬 Mergin Maps 801751 APK [arm64-v8a] Google Play Store #8017
iOS Build 📬 Build number: 26.04.895611 #8956

@gabriel-bolbotina gabriel-bolbotina force-pushed the filter-modify-filter-chip branch from ff9e39c to 0837669 Compare April 16, 2026 13:57
@github-actions
Copy link
Copy Markdown

📦 Build Artifacts Ready

OS Status Build Info Workflow run
macOS Build Build failed or not found. #6706
linux Build 📬 Mergin Maps 67171 x86_64 Expires: 15/07/2026 #6717
win64 Build 📬 Mergin Maps 59011 win64 Expires: 15/07/2026 #5901
Android Build 📬 Mergin Maps 801851 APK [arm64-v8a] Expires: 15/07/2026 #8018
📬 Mergin Maps 801851 APK [arm64-v8a] Google Play Store #8018
Android Build 📬 Mergin Maps 801811 APK [armeabi-v7a] Expires: 15/07/2026 #8018
📬 Mergin Maps 801811 APK [armeabi-v7a] Google Play Store #8018
iOS Build 📬 Build number: 26.04.895711 #8957

Copy link
Copy Markdown
Contributor

@Withalion Withalion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • other things dicussed

Comment thread app/qml/main.qml Outdated
Changed the bahviour of the floating button
@github-actions
Copy link
Copy Markdown

📦 Build Artifacts Ready

OS Status Build Info Workflow run
macOS Build Build failed or not found. #6707
linux Build Build failed or not found. #6718
win64 Build 📬 Mergin Maps 59021 win64 Expires: 16/07/2026 #5902
Android Build 📬 Mergin Maps 801911 APK [armeabi-v7a] Expires: 16/07/2026 #8019
📬 Mergin Maps 801911 APK [armeabi-v7a] Google Play Store #8019
Android Build 📬 Mergin Maps 801951 APK [arm64-v8a] Expires: 16/07/2026 #8019
📬 Mergin Maps 801951 APK [arm64-v8a] Google Play Store #8019
iOS Build 📬 Build number: 26.04.895811 #8958

Comment thread app/filtercontroller.cpp
Comment thread app/filtercontroller.cpp Outdated
Comment thread app/filtercontroller.cpp Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement map tools Something is wrong with recording, geometry editing, splitting, stakeout, ..

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants