Added old logic to handle displayed foreign key and update the UI and…#4428
Merged
Added old logic to handle displayed foreign key and update the UI and…#4428
Conversation
… rawValue Kept the new logic is the field is not displayed
Pull Request Test Coverage Report for Build 23744866307Details
💛 - Coveralls |
📦 Build Artifacts Ready
|
📦 Build Artifacts Ready
|
tomasMizera
approved these changes
Mar 30, 2026
Withalion
reviewed
Mar 30, 2026
Contributor
Withalion
left a comment
Withalion
left a comment
There was a problem hiding this comment.
Great job!
You can spring some more QStringLiterals over it, but it looks good.
📦 Build Artifacts Ready
|
📦 Build Artifacts Ready
|
Withalion
approved these changes
Mar 30, 2026
Withalion
pushed a commit
that referenced
this pull request
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed the issue by using the setFormValue (which updates the UI and uses setAttribute) if the foreign key field is displayed in the child's form, and if not present, adding the value via setAttribute.
Added unit test to check that the rawValue is updated when adding a new child feature