Skip to content

Filter floating chip#4427

Merged
Withalion merged 7 commits intodev/filteringfrom
filter-floating-chip
Apr 6, 2026
Merged

Filter floating chip#4427
Withalion merged 7 commits intodev/filteringfrom
filter-floating-chip

Conversation

@gabriel-bolbotina
Copy link
Copy Markdown
Contributor

@gabriel-bolbotina gabriel-bolbotina commented Mar 27, 2026

Modified the following:

  • position of the filtering chip
  • icon of the chip, deleting the deprecated filled filter icon
  • formatted the code
  • action of the chip, so:
    • one tap will go to the filtering section drawer
    • tap and gold will toggle between enabling and disabling filters, which will fire a toast notification with the change
  • added draft enabled filters member variable in filter controller

Updated visual demo:

filter-chip-update.mov

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 27, 2026

Pull Request Test Coverage Report for Build 24032994354

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 54 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.03%) to 57.891%

Files with Coverage Reduction New Missed Lines %
mm/app/position/providers/simulatedpositionprovider.cpp 1 91.67%
mm/core/merginapi.cpp 3 75.07%
mm/app/mmstyle.h 50 1.85%
Totals Coverage Status
Change from base Build 23803490228: 0.03%
Covered Lines: 8785
Relevant Lines: 15175

💛 - Coveralls

@github-actions
Copy link
Copy Markdown

📦 Build Artifacts Ready

OS Status Build Info Workflow run
macOS Build 📬 Mergin Maps 65821 dmg Expires: 25/06/2026 #6582
linux Build 📬 Mergin Maps 65931 x86_64 Expires: 25/06/2026 #6593
win64 Build 📬 Mergin Maps 57771 win64 Expires: 25/06/2026 #5777
Android Build Build failed or not found. #7894
iOS Build Build failed or not found. #8833

@Withalion Withalion linked an issue Mar 30, 2026 that may be closed by this pull request
Copy link
Copy Markdown
Contributor

@Withalion Withalion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding the questions:

  1. keep the sizes as they are
  2. see the comment below, is it enough?

Comment thread app/qml/map/MMMapController.qml Outdated
Comment thread app/qml/map/MMMapController.qml
Comment thread app/qml/map/MMMapController.qml Outdated
@github-actions
Copy link
Copy Markdown

📦 Build Artifacts Ready

OS Status Build Info Workflow run
macOS Build 📬 Mergin Maps 66201 dmg Expires: 29/06/2026 #6620
linux Build 📬 Mergin Maps 66311 x86_64 Expires: 29/06/2026 #6631
win64 Build 📬 Mergin Maps 58151 win64 Expires: 29/06/2026 #5815
Android Build 📬 Mergin Maps 793251 APK [arm64-v8a] Expires: 29/06/2026 #7932
📬 Mergin Maps 793251 APK [arm64-v8a] Google Play Store #7932
Android Build 📬 Mergin Maps 793211 APK [armeabi-v7a] Expires: 29/06/2026 #7932
📬 Mergin Maps 793211 APK [armeabi-v7a] Google Play Store #7932
iOS Build 📬 Build number: 26.03.887111 #8871

Deleted filled filter icon
Updated visuals for the chip
Changed the chip position
Formatted code
Updated the chip visuals
Updated the filter svg to be 24 x 24
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 1, 2026

📦 Build Artifacts Ready

OS Status Build Info Workflow run
macOS Build 📬 Mergin Maps 66291 dmg Expires: 30/06/2026 #6629
linux Build 📬 Mergin Maps 66401 x86_64 Expires: 30/06/2026 #6640
win64 Build 📬 Mergin Maps 58241 win64 Expires: 30/06/2026 #5824
Android Build 📬 Mergin Maps 794151 APK [arm64-v8a] Expires: 30/06/2026 #7941
📬 Mergin Maps 794151 APK [arm64-v8a] Google Play Store #7941
Android Build 📬 Mergin Maps 794111 APK [armeabi-v7a] Expires: 30/06/2026 #7941
📬 Mergin Maps 794111 APK [armeabi-v7a] Google Play Store #7941
iOS Build 📬 Build number: 26.04.888011 #8880

Added click and hold
Added draft filtersEnabled variable in filter controller
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 1, 2026

📦 Build Artifacts Ready

OS Status Build Info Workflow run
macOS Build 📬 Mergin Maps 66301 dmg Expires: 30/06/2026 #6630
linux Build 📬 Mergin Maps 66411 x86_64 Expires: 30/06/2026 #6641
win64 Build 📬 Mergin Maps 58251 win64 Expires: 30/06/2026 #5825
Android Build 📬 Mergin Maps 794211 APK [armeabi-v7a] Expires: 30/06/2026 #7942
📬 Mergin Maps 794211 APK [armeabi-v7a] Google Play Store #7942
Android Build 📬 Mergin Maps 794251 APK [arm64-v8a] Expires: 30/06/2026 #7942
📬 Mergin Maps 794251 APK [arm64-v8a] Google Play Store #7942
iOS Build 📬 Build number: 26.04.888111 #8881

Copy link
Copy Markdown
Contributor

@Withalion Withalion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove the FilterController change for now and expect the property will be there

Comment thread app/qml/map/MMMapController.qml Outdated
Comment thread app/qml/map/MMMapController.qml Outdated
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 6, 2026

📦 Build Artifacts Ready

OS Status Build Info Workflow run
macOS Build 📬 Mergin Maps 66361 dmg Expires: 05/07/2026 #6636
linux Build 📬 Mergin Maps 66471 x86_64 Expires: 05/07/2026 #6647
win64 Build 📬 Mergin Maps 58311 win64 Expires: 05/07/2026 #5831
Android Build 📬 Mergin Maps 794851 APK [arm64-v8a] Expires: 05/07/2026 #7948
📬 Mergin Maps 794851 APK [arm64-v8a] Google Play Store #7948
Android Build 📬 Mergin Maps 794811 APK [armeabi-v7a] Expires: 05/07/2026 #7948
📬 Mergin Maps 794811 APK [armeabi-v7a] Google Play Store #7948
iOS Build 📬 Build number: 26.04.888711 #8887

@Withalion Withalion merged commit 90c9a09 into dev/filtering Apr 6, 2026
9 checks passed
@Withalion Withalion deleted the filter-floating-chip branch April 6, 2026 18:14
gabriel-bolbotina added a commit that referenced this pull request Apr 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update floating filtering chip visuals

2 participants