Conversation
Pull Request Test Coverage Report for Build 13921058469Details
💛 - Coveralls |
|
please rebase with master (cppcheck fix) |
f88d9c7 to
5a885ee
Compare
|
In case of error, can we use the |
tomasMizera
left a comment
There was a problem hiding this comment.
Just this one change please 😇
|
Suggested project for testing: https://app.merginmaps.com/projects/support/save_images_to_web. |
There was a problem hiding this comment.
Tested on Android 📗
Tested for
- a public image link (https://www.northrivergeographic.com/wp-content/uploads/2024/05/mergin-logo-small-2793196391.png) 🟢
- S3 link (https://rp-test-media-sync.s3.eu-west-1.amazonaws.com/public/Screenshot+from+2025-03-18+15-36-24.png) 🟢
- Google drive 🔴 (https://drive.google.com/file/d/1Xenct9UGIubJNgawErWaUCfln7edqrc8/view?usp=drive_link)
- for QGIS preview see video 😮
- app gives
Could not load the image error
Screencast.from.20-03-25.08.19.37.webm
Thanks @harminius! For Google drive, I suspect it is because GDrive does a redirect when visiting the image. Could you try it with the final link please (https://drive.google.com/file/d/1Xenct9UGIubJNgawErWaUCfln7edqrc8/view)?
That's sick 🙃 I guess QGIS is using webview then |
Ok, I checked and it seems like downloading a public file from GDrive is actually not that easy :) (see https://stackoverflow.com/a/30783921/7875594). Let's merge this one then! |
When loading a photo, we now also verify if it's a url. If the url is valid, we consider it a valid image and proceed to load it. Since some urls might take longer to load, which is beyond our control, a
MMBusyIndicatorhas been added toMMPhototo enhance user experience in cases where loading images from urls might take a while.Screen.Recording.2025-02-19.at.18.36.12.mov
Resolves #2718