Improve Apple container compose compatibility#119
Open
thromel wants to merge 3 commits into
Open
Conversation
5 tasks
b0b30a4 to
1ee22f2
Compare
7 tasks
c46f218 to
d862ae7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This improves compatibility with Apple
containerfor several Compose workflows:depends_onmap form and preserve dependency conditionsservice_started,service_healthy, andservice_completed_successfullynetworksobject form, including aliasescontainercommand parser supports them, while preserving a warning/skip fallback for Apple Container 1.0.0hostname:because Applecontainer run1.0.0 does not currently expose a hostname flag; proposed upstream support remains under discussion in Add container run hostname flag apple/container#1811CMDandCMD-SHELL) with interval/start-period/retry handlingcontainer volumesupport instead of rewriting them into host pathscontainer runcommands as errors, which makes one-shot failures failcompose upRelated issues: #52, #115, #116, #117, and tracker #118.
Apple-side service discovery work is tracked upstream in apple/container#1809. Current upstream PR chain:
container run --hostname, signed and under maintainer discussion; aliases may cover most Compose cases--network name,alias=..., signed, closes [Request]: Add network-scoped aliases for container network attachments apple/container#1839Testing
Static/build checks:
The static test command passed 141 tests.
WaitForeverCpuTestswas skipped because the existing CPU-threshold test is noisy on this machine and unrelated to these changes.Manual Apple
containersmoke tests using the locally builtContainer-Composebinary:up -dcontainer runhostname:emits a warning, does not pass unsupported--hostname, and completes successfully (HOSTNAME_OKlogged)All dynamic test containers, networks, and volumes were cleaned up after the runs.