Skip to content

fix(run): do not pass unsupported --hostname to container run #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
w1zdun wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(run): do not pass unsupported --hostname to container run #101

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions Sources/Container-Compose/Commands/ComposeUp.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -533,11 +533,12 @@ public struct ComposeUp: AsyncParsableCommand, @unchecked Sendable {
print("Note: Service '\(serviceName)' is not explicitly connected to any networks. It will likely use the default bridge network.")
}

// Add hostname
// The 'hostname' field is not supported by `container run` (no --hostname
// flag); passing it would make the whole run command fail to parse.
if let hostname = service.hostname {
let resolvedHostname = resolveVariable(hostname, with: environmentVariables)
runCommandArgs.append("--hostname")
runCommandArgs.append(resolvedHostname)
print(
"Note: Service '\(serviceName)' sets 'hostname: \(hostname)', but the 'container' tool does not support setting a hostname. The field is ignored."
)
}

// Add working directory
Expand Down