Open
Conversation
Signed-off-by: Dave Rodgman <[email protected]>
daverodgman
force-pushed
the
gcc_bswap_fix
branch
from
18f1440 to
9426613
Compare
gilles-peskine-arm
approved these changes
Jan 13, 2026
Contributor
gilles-peskine-arm
left a comment
gilles-peskine-arm
left a comment
There was a problem hiding this comment.
Thanks, LGTM with some very casual look at Godbolt
gilles-peskine-arm
added
needs-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The gcc detection for some reason depended on
__GNUC_PREREQ, which was undefined (AIUI it comes from a header which isn't included here). Replace withMBEDTLS_GCC_VERSION.Presumably size & performance-affecting (I haven't properly measured, but observed eg 17% improvement from this patch in
benchmark ctr_drbg) but not a functional change.PR checklist
Please remove the segment/s on either side of the | symbol as appropriate, and add any relevant link/s to the end of the line.
If the provided content is part of the present PR remove the # symbol.