ci: install Go in CI builder for aws-lc-fips-sys#35849
Closed
jasonhernandez wants to merge 1 commit intoMaterializeInc:mainfrom
Closed
ci: install Go in CI builder for aws-lc-fips-sys#35849jasonhernandez wants to merge 1 commit intoMaterializeInc:mainfrom
jasonhernandez wants to merge 1 commit intoMaterializeInc:mainfrom
Conversation
The upcoming FIPS 140-3 compliance work adds a `fips` feature to mz-ore that enables `aws-lc-rs/fips`, pulling in `aws-lc-fips-sys`. That crate builds BoringSSL's FIPS module from source via cmake, which requires Go for integrity verification. Since `cargo-test` runs with `--all-features`, this feature is activated in CI and the build fails with "Could not find Go". Install Go 1.24.2 in the CI builder image to unblock FIPS feature builds. Fixes SEC-232. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
Contributor
|
Thanks for opening this PR! Here are a few tips to help make the review process smooth for everyone. PR title guidelines
Pre-merge checklist
|
Contributor
Author
|
Folded into PR #35843 (part of the FIPS PR chain where the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Install Go 1.24.2 in the CI builder image (
ci/builder/Dockerfile). Required byaws-lc-fips-sys, which builds BoringSSL's FIPS module from source and needs Go for integrity verification.This is needed because
cargo-testruns with--all-features, which enables themz-orefipsfeature →aws-lc-rs/fips→aws-lc-fips-sys→ cmake → requires Go.Without this,
rust-cargo-test-2fails with:Change
Fixes SEC-232.
Test plan
rust-cargo-test-2passes with--all-features(no more "Could not find Go")🤖 Generated with Claude Code