Add check for MySQL system variable binlog_row_metadata when using new CTFS syntax#35839
Open
patrickwwbutler wants to merge 4 commits intoMaterializeInc:mainfrom
Open
Add check for MySQL system variable binlog_row_metadata when using new CTFS syntax#35839patrickwwbutler wants to merge 4 commits intoMaterializeInc:mainfrom
patrickwwbutler wants to merge 4 commits intoMaterializeInc:mainfrom
Conversation
Contributor
|
Thanks for opening this PR! Here are a few tips to help make the review process smooth for everyone. PR title guidelines
Pre-merge checklist
|
martykulma
approved these changes
Apr 3, 2026
| #[error(transparent)] | ||
| InvalidConnection(#[from] MySqlConnectionValidationError), | ||
| #[error( | ||
| "The MySQLsystem variable 'binlog_row_metadata' is set to an unsupported value: {setting}. Materialize requires this variable to be set to 'FULL' to use the \"CREATE TABLE FROM SOURCE\" syntax for MySQL sources." |
Contributor
There was a problem hiding this comment.
s/MySQLsystem/MySQL system/
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in S&S team meeting, we should enforce that this sysvar is set when a user wants to use the new syntax, as it is a requirement for source versioning.
Description
Adds a check during purification for this sysvar, along with a corresponding new error type and testdrive.