refactor: merge project checkers sharing keyword usage iteration - #1917
Merged
Conversation
Combine project checkers that each looped over every keyword call into single visitors reusing one context.iter_usages() pass, mirroring the multi-rule VisitorChecker pattern. - usage.py: merge KeywordNotFound, AmbiguousKeywordNames and MissingKeywordPrefix into KeywordUsageChecker. - keyword_arguments.py: merge ProjectArgumentsChecker and ProjectArgumentNamesChecker. Per-rule enabled guards preserve the previous skip-when-disabled behavior. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This was referenced Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Merges project checkers that iterate the same project data into single visitors, reusing one
context.iter_usages()pass — mirroring the multi-ruleVisitorCheckerpattern already used elsewhere.linter/checkers/usage.pyCombined three checkers that each looped over every keyword call into one
KeywordUsageCheckerhandling all three rules:KeywordNotFound+AmbiguousKeywordNames+MissingKeywordPrefix→KeywordUsageChecker(keyword-not-found,ambiguous-keyword-name,missing-keyword-prefix)UnusedKeywordsleft separate (it loopsiter_files(), notiter_usages()).linter/checkers/keyword_arguments.pyProjectArgumentsChecker+ProjectArgumentNamesChecker→ProjectArgumentsChecker(invalid-argument-count,missing-argument-name)Notes
enabledflag, preserving the previous behavior where a checker only did expensive keyword resolution when its rule was selected (including the "skip when no library loader" short-circuit forkeyword-not-found)._check_*helpers; the rules remain declarative.Testing
keyword-not-found,ambiguous-keyword-name,missing-keyword-prefix,invalid-argument-count,missing-argument-name,unused-keyword) pass.tests/projectsuite (179 tests) passes.ruff checkandmypy --strictclean.