Add new "scp_socket_timeout" parameter to "Open Connection"#479
Open
NSavatier wants to merge 1 commit intoMarketSquare:masterfrom
Open
Add new "scp_socket_timeout" parameter to "Open Connection"#479NSavatier wants to merge 1 commit intoMarketSquare:masterfrom
NSavatier wants to merge 1 commit intoMarketSquare:masterfrom
Conversation
This allows to expose the "socket_timeout" parameter of SCPClient. It allows users to define a specific timeout when the connection used is not stable, and default timeout of 10s is too short.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
The idea of this PR is expose the socket_timeout parameter of the underlying SCPClient (see https://github.com/jbardin/scp.py/blob/master/scp.py#L117) to users of the SSHLibrary via a new parameter of the keyword "Open Connection".
That way, the user of the Library may configure the timeout used for scp operations, for cases when it is too short.
This solves this issue: #397
And is quite similar to this PR #423 (my code is inspired from it with some minor changes).
I've added a few simple tests to cover this new parameter, please let me know if they seem sufficient.