fix: repair StitcherService#126
Open
christopher-hampson wants to merge 1 commit intoManimCommunity:mainfrom
Open
fix: repair StitcherService#126christopher-hampson wants to merge 1 commit intoManimCommunity:mainfrom
christopher-hampson wants to merge 1 commit intoManimCommunity:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview: What does this pull request change?
This PR repairs
StitcherServiceby making two small changes inmanim_voiceover/services/stitcher.py:_StitcherServicetoStitcherServiceto make part of the publicly accessible API"path"storesdata_hash + ".mp3"rather thanoutput_path(which currently results in a duplicationmedia\voiceovers\media\voiceovers)Motivation and Explanation: Why and how do your changes improve the library?
The use of
StitcherServiceis regularly requested by users on Discord as a way to use their own pre-recorded audio in their videos and is more robust that theRecorderService.This bugfix makes the
StitcherServiceusable as a service, without needing to explicitly specify acache_dir.Links to added or changed documentation pages
Further Information and Comments
Fix first diagnosed and suggested in #88.