Add :stopped to opts when stopped by on_stop#105
Open
wishdev wants to merge 2 commits intoManageIQ:masterfrom
Open
Add :stopped to opts when stopped by on_stop#105wishdev wants to merge 2 commits intoManageIQ:masterfrom
wishdev wants to merge 2 commits intoManageIQ:masterfrom
Conversation
Fryguy
reviewed
May 23, 2019
Member
Fryguy
left a comment
Fryguy
left a comment
There was a problem hiding this comment.
Technically, this could break any existing users that may have stopped as an option. Though, I'm not sure there's any "nice" way to do this given the hash. Maybe prefix the symbol with an underscore (i.e. :_stopped)
Author
|
:_stopped sounds perfect to me - good catch on the possible conflict |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I would like to have the parser set a value if on_stop finds a keyword in the args. Otherwise I need to parse the first argument of ARGV in order to determine whether or not a valid command was given (in a command/subcommand scenario).
Only adds it if on_stop exists.