convert console_supported? to supports?

[kbrock]

part of ManageIQ/manageiq#21990

[miq-bot]

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s)

Thank you for all your contributions! More information about the ManageIQ triage process can be found in the triage process documentation.

[miq-bot]

This pull request has been automatically closed because it has not been updated for at least 3 months.

Feel free to reopen this pull request if these changes are still valid.

Thank you for all your contributions! More information about the ManageIQ triage process can be found in the triage process documentation.

[kbrock]

outstanding:
This needs to be split up.
the PR got away from me

[miq-bot]

Checked commits kbrock/manageiq-providers-vmware@0aef0d0~...2e9ced0 with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint
5 files checked, 3 offenses detected

app/models/manageiq/providers/vmware/infra_manager/vm/remote_console.rb

• 💣 💥 🔥 🚒 - Line 155, Col 1 - Lint/Syntax - unexpected token kEND
  (Using Ruby 2.6 parser; configure using TargetRubyVersion parameter, under AllCops)
• 💣 💥 🔥 🚒 - Line 17, Col 27 - Lint/Syntax - unexpected token tLCURLY
  (Using Ruby 2.6 parser; configure using TargetRubyVersion parameter, under AllCops)
• 💣 💥 🔥 🚒 - Line 17, Col 58 - Lint/Syntax - unexpected token tRCURLY
  (Using Ruby 2.6 parser; configure using TargetRubyVersion parameter, under AllCops)

[miq-bot]

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).

[miq-bot]

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).

[miq-bot]

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).

[miq-bot]

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).

[miq-bot]

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).

[miq-bot]

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).

[miq-bot]

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).

[miq-bot]

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).

[agrare]

It looks like this only supported webmks previously, would html5 have been supported before even though console_supported?(html5) would have been false?

Suggested change

supports :html5_console