Open
Conversation
Fryguy
force-pushed
the
fix_truffleruby
branch
2 times, most recently
from
f00acb8 to
29de4f4
Compare
Before this commit, they were passing as a false positive, hiding any actual failures. They will now fail as expected.
Until we can get to fixing these tests, better to let it pass CI (but still show as failing) as opposed to passing with a false positive.
Fryguy
force-pushed
the
fix_truffleruby
branch
from
29de4f4 to
271ee08
Compare
Member
Author
|
@agrare For now, I marked truffleruby continue-on-error. This way until we can get to fixing these tests, better to let it pass CI (but still show as failing) as opposed to passing with a false positive. |
Member
Author
|
Mah, I don't love this either - Not sure how to make this nice. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed in #653 that the tests "run", but nothing actually runs. This PR should correct that.