remove vcr tests because hooking into webmock breaks multithreaded tests#495
Merged
cben merged 1 commit intoManageIQ:masterfrom Mar 6, 2021
Merged
remove vcr tests because hooking into webmock breaks multithreaded tests#495cben merged 1 commit intoManageIQ:masterfrom
cben merged 1 commit intoManageIQ:masterfrom
Conversation
Collaborator
|
I guess you're right. I was recently thinking to automate some version of k8s that's easy to start, e.g. k3s, to be able to reproducibly re-record it the VCR. But if we make something like that, we don't need VCR, we could get real end-to-end testing. As it is, the VCR test is not worth much. |
Collaborator
|
Don't know yet what's going on with truffleruby. Added it to #435 checklist so we don't forget. This PR is obviously safe, merging. |
cben
added a commit
to cben/kubeclient
that referenced
this pull request
Feb 27, 2022
VCR was interfering with my attempts to connect to a real cluster, despite `WebMock.enable_net_connect!`. What's worse, it depended on order that tests executed. [This won't be needed on master, we dropped the VCR test in ManageIQ#495.]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#494 breaks when VCR is enabled .. somehow it ends up executing the stubs on all threads
can reproduce by adding to test/test_helper.rb
and running
ruby test/test_informer.rbthe guestbook test itself seems rather brittle / not reproducible, so I'm thinking best get rid of it instead of pouring more work into it