Skip to content

Dfuds implementation#46

Merged
Sanya239 merged 11 commits into
mainfrom
dfuds-implementation
Jun 2, 2026
Merged

Dfuds implementation#46
Sanya239 merged 11 commits into
mainfrom
dfuds-implementation

Conversation

@Sanya239
Copy link
Copy Markdown
Collaborator

No description provided.

@Sanya239 Sanya239 requested a review from Malkovsky May 14, 2026 22:35
Comment thread include/pixie/dfuds_tree.h Outdated
/**
* @brief Returns the size of the tree
*/
size_t size() const { return num_bits_ / 2; }
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WARNING: size() returns an incorrect node count

num_bits_ is initialized as 2 * tree_size - 1, so num_bits_ / 2 evaluates to tree_size - 1 for all non-empty trees. This under-reports the actual tree size by one and can break callers relying on size() for bounds or traversal logic.

Comment thread scripts/coverage_report.sh Outdated
"${BUILD_DIR}/unittests"
"${BUILD_DIR}/excess_positions_tests"
"${BUILD_DIR}/louds_tree_tests"
"${BUILD_DIR}/dfus_tree_tests"

This comment was marked as outdated.

@kilo-code-bot
Copy link
Copy Markdown
Contributor

kilo-code-bot Bot commented May 14, 2026

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (1 files)
  • include/pixie/dfuds_tree.h

Reviewed by gpt-5.3-codex · 123,918 tokens

@Sanya239 Sanya239 force-pushed the dfuds-implementation branch 3 times, most recently from a6575a7 to c447002 Compare May 14, 2026 23:03
@codecov
Copy link
Copy Markdown

codecov Bot commented May 14, 2026

Codecov Report

❌ Patch coverage is 98.56115% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.22%. Comparing base (4ea1aaf) to head (4ebdc42).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
include/pixie/dfuds_tree.h 96.49% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #46      +/-   ##
==========================================
- Coverage   89.58%   89.22%   -0.37%     
==========================================
  Files          15       17       +2     
  Lines        4416     4556     +140     
  Branches      814      828      +14     
==========================================
+ Hits         3956     4065     +109     
- Misses        280      284       +4     
- Partials      180      207      +27     
Flag Coverage Δ
gcov 89.22% <98.56%> (-0.37%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Sanya239 Sanya239 force-pushed the dfuds-implementation branch from 965798b to 8da3cca Compare May 27, 2026 15:41
@Sanya239 Sanya239 force-pushed the dfuds-implementation branch from 8da3cca to e32c846 Compare May 27, 2026 16:05
@Sanya239 Sanya239 merged commit 7445639 into main Jun 2, 2026
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants