Skip to content

PositivityToricBundles for JSAG#4135

Draft
a-hochenegger wants to merge 2 commits intoMacaulay2:developmentfrom
a-hochenegger:development
Draft

PositivityToricBundles for JSAG#4135
a-hochenegger wants to merge 2 commits intoMacaulay2:developmentfrom
a-hochenegger:development

Conversation

@a-hochenegger
Copy link
Contributor

Comments welcome!

@d-torrance d-torrance added the JSAG Under review for the Journal of Software for Algebra and Geometry label Feb 19, 2026
@d-torrance d-torrance marked this pull request as draft February 20, 2026 02:59
@d-torrance
Copy link
Member

A couple quick notes:

  • Verbosity is exported by Core, so there's no reason to re-export (or re-protect) it.
  • The other exported options (DrawCohomology and DrawChernCharacter) don't need to be protected, since that happens automatically for exported symbols.

@a-hochenegger
Copy link
Contributor Author

a-hochenegger commented Feb 24, 2026

@d-torrance thanks for the notes, which are now fixed.

Something different: I want to report that the instructions how to do a pull request for Macaulay2 didn't work very well for me:
https://github.com/Macaulay2/M2/wiki/Pull-Requests
There is a complain when arriving at the step git checkout development.

For me worked the following steps:

  1. fork on https://github.com/Macaulay2/M2/fork, where it is important to uncheck the option "Copy the main branch only".
  2. clone the development branch with
    git clone -b development [email protected]:<USERNAME>/M2.git && cd M2

@d-torrance
Copy link
Member

Thanks for the notes! Would you be willing to make the suggested modifications to the wiki page?

@a-hochenegger
Copy link
Contributor Author

a-hochenegger commented Feb 25, 2026

I am not an expert with git, so I do not dare to change the wiki-page directly.

In the attached markdown-file, there is the wiki-page with some changes (mostly in the section with the instructions how to fork), which works for me :
instructions.md
If you think that these instructions should work well for everyone, let me know and I would change also the wiki-page.

@d-torrance
Copy link
Member

These changes are great -- thank you! If you'd update the wiki accordingly, then it would be much appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

JSAG Under review for the Journal of Software for Algebra and Geometry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants