Remove Mental health and nutrition from matsapha frontend#352
Remove Mental health and nutrition from matsapha frontend#352
Conversation
|
Oops! Your Typo free trial has ended. If you'd like to continue receiving code reviews, please ask the admin to check out our special pricing plan. |
| <properties> | ||
| <property> | ||
| <name>modulesToRemove</name> | ||
| <value>esm-mental-health-app,esm-nutrition-app</value> |
There was a problem hiding this comment.
Based on the logic, it looks like each site needs to maintain a version of this block to remove any unused esms. 3 questions
- Does the removal happen at before the build or after?
- What happens for the reverse scenario where bunia will need ward, bed and stock management? Does that mean the main importmap will have all the packages and remove at site level?
- How does this approach work for experimental packages/modules that aren't supposed to be in any of the sites but available on a demo instance with new expeirmental features?
There was a problem hiding this comment.
Does the removal happen at before the build or after?
After the build. Actually, last step of generating the .zip
Does that mean the main importmap will have all the packages and remove at site level?
Yes, distro will have everything. Sites will remove what they do not need.
How does this approach work for experimental packages/modules that aren't supposed to be in any of the sites but available on a demo instance with new expeirmental features?
We shall remove experimental packages/modules at sites where they are not needed.
| <properties> | ||
| <property> | ||
| <name>modulesToRemove</name> | ||
| <value>esm-mental-health-app,esm-nutrition-app</value> |
There was a problem hiding this comment.
@jnsereko , we must use the correct app names: @openmrs/esm-mental-health-app
There was a problem hiding this comment.
we can use both the short or the long names of the app. Whichever you like eg
Short name: esm-mental-health-app
full name: @openmrs/esm-mental-health-app
There was a problem hiding this comment.
Can we use json to list this package names? This doesn't look organized
There was a problem hiding this comment.
Can we use json to list this package names? This doesn't look organized
I’m not sure introducing a JSON file here would add much value. It might actually introduce extra complexity.
If we do decide to go the JSON route, then we should probably support overriding the import map from the distro level rather than just listing package names separately.
🐞 Related Issues / Tickets
Added a script,
remove-importmap-entries.groovythat removes all frontend modules whose names are supplied as parameters the scriptScreen cast
✅ PR Checklist
👨💻 For Author
LIME2-123)🔍 For Reviewer