amp2response: Fix non-standard directions access - #3425
Open
Lestropie wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug not previously caught due to absent test coverage.
Probably when I first started implementing
amp2response, I commenced with a single-shell implementation, then when I expanded it to handle multi-shell in a single run I failed to update the non-standard code paths accordingly.Current code erroneously initialises the set of volumes to use during response function estimation to be "all volumes up to index 0", as it erroneously selects the number of unique shells as the number of volumes. There is one direction matrix per shell, so where one of these code paths applies, there is both definitionally and obviously from the preceding code only one shell, and so what is actually required is the number of rows (= # volumes) in the direction matrix of the solitary shell.