silence VLA warnings when compiling with clang - #3420
Open
jdtournier wants to merge 1 commit into
Open
Conversation
Lestropie
approved these changes
Jul 18, 2026
Lestropie
left a comment
Lestropie
left a comment
Member
There was a problem hiding this comment.
Looks fine for master.
For dev I think removing the functionality altogether is more appealing. There are very few usages remaining and I don't see any strong justification for why those particular usages should be VLA unlike eg. std::vector used in every other circumstance. The only one that arguably justifies stack memory use is MR::printf(), and that would disappear with #3339.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use clang-specific pragmas to silence the many warnings about the use of variable-length arrays.