Timx 528 merge append deltas#163
Merged
jonavellecuerdo merged 2 commits intoepic-TIMX-515from Aug 15, 2025
Merged
Conversation
ghukill
requested changes
Aug 14, 2025
Contributor
ghukill
left a comment
ghukill
left a comment
There was a problem hiding this comment.
Overall, looks excellent! Nice work here. And thanks for the discussions leading up to the PR, I think they were helpful for scoping this work and even catching some other rough edges.
My request is for a bit more testing. While I think a pure count check is good, this merging is pretty important. I think we might benefit from a test that unambiguously confirms that records X,Y,Z from the append deltas are now in the stastic DB after the merge.
ghukill
approved these changes
Aug 15, 2025
Contributor
ghukill
left a comment
ghukill
left a comment
There was a problem hiding this comment.
Looks good! Nice work all around.
Why these changes are being introduced: * The method for merging append deltas into the static metadata database file needs the filenames of append deltas to easily identify which files to delete (once merged). Prior to this change, the append deltas view only had a 'filename' column, which referred to the path or S3 URI for the TIMDEXDataset parquet file. How this addresses that need: * Set filename='append_delta_filename' when creating metadata.append_deltas view * Explicitly select metadata column names when creating metadata.records view Side effects of this change: * None Relevant ticket(s): * https://mitlibraries.atlassian.net/browse/TIMX-528
Why these changes are being introduced: * TDA requires a method to support regular merging of append deltas into the static metadata.duckdb database file as new rows and then deletes (the append deltas) once merged. How this addresses that need: * Add 'merge_append_deltas' method * Add unit test Side effects of this change: * It's worth noting that this method, when run, will delete the append delta parquet files that existed in the directory at the time of execution. Relevant ticket(s): * https://mitlibraries.atlassian.net/browse/TIMX-528
jonavellecuerdo
force-pushed
the
TIMX-528-merge-append-deltas
branch
from
90acfa7 to
3a30eaa
Compare
Pull Request Test Coverage Report for Build 16995837471Details
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose and background context
TDA requires a method to support regular merging of append deltas into the static
metadata.duckdbdatabase file as new rows and then deletes (the append deltas) once merged. This work is encapsulated in the second commit. The updates in the first commit was a prerequisite for the merging method.How can a reviewer manually see the effects of these changes?
For review purposes, the added unit test provides a detailed overview of the method's functionality.
Includes new or updated dependencies?
NO
Changes expectations for external applications?
NO
What are the relevant tickets?