feat: update VS Code host profile to 1.130#3380
Conversation
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
GitHub Actions
Inactive
dosubot
Bot
added
size:XL
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Internal previewPreview URL: https://mcp-inspector-pr-3380.up.railway.app |
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughUpdates VS Code MCP Apps capabilities to match a VS Code 1.130.0 probe, including display modes, capability flags, host capability shapes, and widget request behavior. Adds host capability replacement support to style resolution and applies it to the VS Code built-in style. Refreshes the VS Code host template with client capabilities, host context styling, sandbox configuration, MCP profile metadata, and app overrides. Adds compatibility evidence schemas and catalog types, updates ChatGPT and Copilot seed data, and expands related tests. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
sdk/src/host-config/templates/seed-host-template.ts (1)
1780-1799: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win
mcpAppsOverridesduplicatesMCP_APPS_VSCODEfield-for-field.Both live in the
sdkpackage; this literal is a verbatim, static copy ofMCP_APPS_VSCODEfromsdk/src/host-compat/capabilities.ts. If the probe capture is ever refreshed there, this seed silently drifts unless someone remembers to update it in lockstep.♻️ Proposed fix: derive from the shared constant
- mcpAppsOverrides: { - availableDisplayModes: ["inline"], - toolInputPartial: false, - toolCancelled: false, - hostContextChanged: true, - resourceTeardown: false, - toolInfo: false, - openLinks: true, - serverTools: true, - serverResources: true, - logging: true, - updateModelContext: true, - message: false, - sandboxPermissions: true, - cspFrameDomains: false, - cspBaseUriDomains: false, - resourcePrefersBorder: false, - downloadFile: true, - requestTeardown: false, - widgetDisplayModeRequests: "decline", - }, + mcpAppsOverrides: { ...MCP_APPS_VSCODE },(plus importing
MCP_APPS_VSCODEfrom../../host-compat/capabilitiesat the top of the file, adjusted to the actual relative path.)🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@sdk/src/host-config/templates/seed-host-template.ts` around lines 1780 - 1799, Replace the duplicated mcpAppsOverrides literal in the seed host template with the shared MCP_APPS_VSCODE constant, importing it from the host-compat capabilities module using the correct relative path. Preserve the existing template structure while ensuring the generated configuration derives directly from MCP_APPS_VSCODE.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@sdk/src/host-config/templates/seed-host-template.ts`:
- Around line 1780-1799: Replace the duplicated mcpAppsOverrides literal in the
seed host template with the shared MCP_APPS_VSCODE constant, importing it from
the host-compat capabilities module using the correct relative path. Preserve
the existing template structure while ensuring the generated configuration
derives directly from MCP_APPS_VSCODE.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 176009cc-983f-4e4b-a618-2b2ed8008be2
⛔ Files ignored due to path filters (2)
sdk/src/host-compat/catalog.generated.tsis excluded by!**/*.generated.*sdk/tests/__snapshots__/host-config-seed-host-template.test.ts.snapis excluded by!**/*.snap
📒 Files selected for processing (10)
mcpjam-inspector/client/src/lib/__tests__/client-config-v2.test.tsmcpjam-inspector/client/src/lib/client-config-v2.tsmcpjam-inspector/client/src/lib/client-styles/__tests__/registry.test.tsmcpjam-inspector/client/src/lib/client-styles/built-ins.tsmcpjam-inspector/client/src/lib/client-styles/index.tsmcpjam-inspector/client/src/lib/client-styles/registry.tsmcpjam-inspector/client/src/lib/client-styles/types.tssdk/src/host-compat/capabilities.tssdk/src/host-config/templates/seed-host-template.tssdk/tests/host-config-seed-host-template.test.ts
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 issue found across 12 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="mcpjam-inspector/client/src/lib/client-styles/built-ins.ts">
<violation number="1" location="mcpjam-inspector/client/src/lib/client-styles/built-ins.ts:595">
P2: VS Code is advertised as supporting `serverTools.listChanged` and `serverResources.listChanged`, but the inspector renderer does not forward those list-changed notifications. Widgets can therefore take the supported path and retain stale tool/resource lists. The preset would be safer with these sub-capabilities omitted or set to `false` until notification forwarding is implemented, or the renderer should implement the advertised behavior.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
| serverTools: { listChanged: true }, | ||
| serverResources: { listChanged: true }, |
There was a problem hiding this comment.
P2: VS Code is advertised as supporting serverTools.listChanged and serverResources.listChanged, but the inspector renderer does not forward those list-changed notifications. Widgets can therefore take the supported path and retain stale tool/resource lists. The preset would be safer with these sub-capabilities omitted or set to false until notification forwarding is implemented, or the renderer should implement the advertised behavior.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At mcpjam-inspector/client/src/lib/client-styles/built-ins.ts, line 595:
<comment>VS Code is advertised as supporting `serverTools.listChanged` and `serverResources.listChanged`, but the inspector renderer does not forward those list-changed notifications. Widgets can therefore take the supported path and retain stale tool/resource lists. The preset would be safer with these sub-capabilities omitted or set to `false` until notification forwarding is implemented, or the renderer should implement the advertised behavior.</comment>
<file context>
@@ -578,41 +579,32 @@ export const CODEX_HOST_STYLE: HostStyleDefinition = {
hostCapabilitiesAugment: {
- serverTools: { listChanged: false },
- serverResources: { listChanged: false },
+ serverTools: { listChanged: true },
+ serverResources: { listChanged: true },
+ },
</file context>
| serverTools: { listChanged: true }, | |
| serverResources: { listChanged: true }, | |
| serverTools: { listChanged: false }, | |
| serverResources: { listChanged: false }, |
GitHub Actions
Inactive
GitHub Actions
Inactive
There was a problem hiding this comment.
2 issues found across 10 files (changes from recent commits).
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="sdk/src/host-compat/catalog-schema.ts">
<violation number="1" location="sdk/src/host-compat/catalog-schema.ts:130">
P3: Several required string fields in `hostCompatibilityEvidenceSchema.deployment` use bare `z.string()` while sibling fields use `.min(1)` to reject empty strings. An empty version label, discovery mode, redirect URI, or surface name is not meaningful and inconsistent validation creates future confusion about the expected contract. Consider adding `.min(1)` to `widgetHostPattern`, `minimumAgentsToolkitVersion`, `defaultToolDiscovery`, `surface`, and `uri` for consistency with `profileLabel` and `sourceUrl`.</violation>
</file>
<file name="sdk/src/host-config/templates/seed-host-template.ts">
<violation number="1" location="sdk/src/host-config/templates/seed-host-template.ts:1772">
P2: Widgets will exercise lifecycle, resource-metadata, teardown, and display-mode paths that have not been verified for VS Code. Keep these capabilities disabled (or omit the overrides) until a probe establishes them, rather than treating emulator defaults as host evidence.</violation>
</file>
Tip: Review your code locally with the cubic CLI to iterate faster.
Re-trigger cubic
| // The handshake probe did not exercise lifecycle, display-request, | ||
| // or resource-metadata behavior, so retain the existing emulator | ||
| // defaults for those dimensions. | ||
| toolInputPartial: true, |
There was a problem hiding this comment.
P2: Widgets will exercise lifecycle, resource-metadata, teardown, and display-mode paths that have not been verified for VS Code. Keep these capabilities disabled (or omit the overrides) until a probe establishes them, rather than treating emulator defaults as host evidence.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At sdk/src/host-config/templates/seed-host-template.ts, line 1772:
<comment>Widgets will exercise lifecycle, resource-metadata, teardown, and display-mode paths that have not been verified for VS Code. Keep these capabilities disabled (or omit the overrides) until a probe establishes them, rather than treating emulator defaults as host evidence.</comment>
<file context>
@@ -1749,10 +1766,13 @@ export const HOST_TEMPLATES: readonly HostTemplate[] = [
+ // The handshake probe did not exercise lifecycle, display-request,
+ // or resource-metadata behavior, so retain the existing emulator
+ // defaults for those dimensions.
+ toolInputPartial: true,
+ toolCancelled: true,
hostContextChanged: true,
</file context>
| uri: z.string(), | ||
| }) | ||
| ), | ||
| minimumAgentsToolkitVersion: z.string(), |
There was a problem hiding this comment.
P3: Several required string fields in hostCompatibilityEvidenceSchema.deployment use bare z.string() while sibling fields use .min(1) to reject empty strings. An empty version label, discovery mode, redirect URI, or surface name is not meaningful and inconsistent validation creates future confusion about the expected contract. Consider adding .min(1) to widgetHostPattern, minimumAgentsToolkitVersion, defaultToolDiscovery, surface, and uri for consistency with profileLabel and sourceUrl.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At sdk/src/host-compat/catalog-schema.ts, line 130:
<comment>Several required string fields in `hostCompatibilityEvidenceSchema.deployment` use bare `z.string()` while sibling fields use `.min(1)` to reject empty strings. An empty version label, discovery mode, redirect URI, or surface name is not meaningful and inconsistent validation creates future confusion about the expected contract. Consider adding `.min(1)` to `widgetHostPattern`, `minimumAgentsToolkitVersion`, `defaultToolDiscovery`, `surface`, and `uri` for consistency with `profileLabel` and `sourceUrl`.</comment>
<file context>
@@ -88,6 +88,51 @@ const hostImageSupportSchema = z.object({
+ uri: z.string(),
+ })
+ ),
+ minimumAgentsToolkitVersion: z.string(),
+ defaultToolDiscovery: z.string(),
+ notes: z.array(z.string()),
</file context>
There was a problem hiding this comment.
All reported issues were addressed across 10 files (changes from recent commits).
Tip: Review your code locally with the cubic CLI to iterate faster.
Re-trigger cubic
GitHub Actions
Error
GitHub Actions
Inactive
MCP worker previewPreview URL: https://mcpjam-mcp-pr-3380.marcelo-1cb.workers.dev |
GitHub Actions
Inactive
There was a problem hiding this comment.
1 issue found across 4 files (changes from recent commits).
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="mcpjam-inspector/client/src/components/hosts/comparison/HostConfigCompareView.tsx">
<violation number="1" location="mcpjam-inspector/client/src/components/hosts/comparison/HostConfigCompareView.tsx:617">
P3: At narrow mobile widths, the new Theme action is clipped from the public action row because all four labeled buttons are forced onto one non-wrapping flex line. Let this action row wrap (or compact labels/icons at small widths) so every action remains reachable.</violation>
</file>
Tip: Review your code locally with the cubic CLI to iterate faster.
Re-trigger cubic
| searchQuery={fieldSearchQuery} | ||
| fields={compareFields} | ||
| /> | ||
| <ThemeToggleButton /> |
There was a problem hiding this comment.
P3: At narrow mobile widths, the new Theme action is clipped from the public action row because all four labeled buttons are forced onto one non-wrapping flex line. Let this action row wrap (or compact labels/icons at small widths) so every action remains reachable.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At mcpjam-inspector/client/src/components/hosts/comparison/HostConfigCompareView.tsx, line 617:
<comment>At narrow mobile widths, the new Theme action is clipped from the public action row because all four labeled buttons are forced onto one non-wrapping flex line. Let this action row wrap (or compact labels/icons at small widths) so every action remains reachable.</comment>
<file context>
@@ -603,6 +614,7 @@ export function HostConfigCompareView({
searchQuery={fieldSearchQuery}
fields={compareFields}
/>
+ <ThemeToggleButton />
</div>
) : undefined
</file context>
2 participants
Summary by cubic
Updates the VS Code host profile to 1.130 with inline-only MCP Apps, a typed updateModelContext (no text), captured light/dark theme colors, and persisted webview sandbox settings. Adds a light/dark toggle and a responsive header (dynamic width) to the public CanIUse page, and syncs catalog/templates (Copilot 1.0.1 evidence + OpenAI Apps overrides; ChatGPT capability fixes) while keeping unprobed VS Code behavior at emulator defaults.
New Features
compatibilityEvidenceand explicitopenaiAppsOverrides; ChatGPT corrected toserverResources/loggingon anddownloadFileoff; refreshed protocol versions and timestamps.Refactors
buildHostCapabilitiessupports a replacement map;HostMcpProfile.hostCapabilitiesReplacementpreserves exact host shapes (used for VS Code’s typedupdateModelContext); introducedMCP_APPS_VSCODEin@mcpjam/sdk/host-compat.Written for commit 2d1c800. Summary will update on new commits.