[logging] inspector: convert second-wave hosted routes to typed events#1933
[logging] inspector: convert second-wave hosted routes to typed events#1933
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
a6a4858 to
475f85c
Compare
f81b256 to
f17abdd
Compare
475f85c to
9176f0d
Compare
f17abdd to
88ec9a6
Compare
9176f0d to
cfcdbfc
Compare
88ec9a6 to
96ee129
Compare
cfcdbfc to
e1a52f4
Compare
96ee129 to
0136f80
Compare
0136f80 to
bf47dba
Compare
e1a52f4 to
5369c35
Compare
5369c35 to
fe15c8a
Compare
bf47dba to
836264c
Compare
836264c to
d3e3d78
Compare
fe15c8a to
3ceaa47
Compare
d3e3d78 to
d505dee
Compare
3ceaa47 to
58d5256
Compare
58d5256 to
fe228fc
Compare
d505dee to
3aa9855
Compare
Adds mcp.tool.execution.failed to the event map and emits it from the /execute callback catch. Converts web/oauth.ts proxy, metadata, and debug/proxy routes to emit mcp.oauth.proxy.failed. resources.ts and prompts.ts have no explicit error paths beyond withEphemeralConnection delegation so are left unchanged. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
fe228fc to
a41775b
Compare
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
WalkthroughThe changes add structured error logging to three distinct failure points. OAuth proxy and metadata endpoints now emit categorized failure events containing the target hostname, phase indicator, and error classification. The tool execution endpoint adds similar logging when tool execution fails, capturing tool and server identifiers alongside error codes. A corresponding request event type is introduced to formalize the tool execution failure log schema. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |

Adds mcp.tool.execution.failed to the event map and emits it from the
/execute callback catch. Converts web/oauth.ts proxy, metadata, and
debug/proxy routes to emit mcp.oauth.proxy.failed. resources.ts and
prompts.ts have no explicit error paths beyond withEphemeralConnection
delegation so are left unchanged.
Co-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com