Skip to content

[logging] inspector: convert second-wave hosted routes to typed events#1933

Merged
Vu-John merged 1 commit intomainfrom
logging-inspector-route-conversions-wave-2
Apr 26, 2026
Merged

[logging] inspector: convert second-wave hosted routes to typed events#1933
Vu-John merged 1 commit intomainfrom
logging-inspector-route-conversions-wave-2

Conversation

@Vu-John
Copy link
Copy Markdown
Collaborator

@Vu-John Vu-John commented Apr 26, 2026

Adds mcp.tool.execution.failed to the event map and emits it from the
/execute callback catch. Converts web/oauth.ts proxy, metadata, and
debug/proxy routes to emit mcp.oauth.proxy.failed. resources.ts and
prompts.ts have no explicit error paths beyond withEphemeralConnection
delegation so are left unchanged.

Co-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com

@Vu-John Vu-John temporarily deployed to preview-pr-1933 April 26, 2026 01:18 — with GitHub Actions Inactive
@chelojimenez
Copy link
Copy Markdown
Contributor

chelojimenez commented Apr 26, 2026

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 26, 2026

Internal preview

Preview URL will appear in Railway after the deploy finishes.
Deployed commit: 37cb601
PR head commit: fe228fc
Backend target: staging fallback.
Access is employee-only in non-production environments.

@Vu-John Vu-John marked this pull request as ready for review April 26, 2026 01:33
@chatgpt-codex-connector
Copy link
Copy Markdown

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

@dosubot dosubot Bot added size:M This PR changes 30-99 lines, ignoring generated files. enhancement New feature or request labels Apr 26, 2026
@Vu-John Vu-John force-pushed the logging-inspector-route-conversions-wave-2 branch from a6a4858 to 475f85c Compare April 26, 2026 01:42
@Vu-John Vu-John force-pushed the logging-inspector-route-conversions-wave-1 branch from f81b256 to f17abdd Compare April 26, 2026 01:42
@Vu-John Vu-John temporarily deployed to preview-pr-1933 April 26, 2026 01:42 — with GitHub Actions Inactive
@Vu-John Vu-John force-pushed the logging-inspector-route-conversions-wave-2 branch from 475f85c to 9176f0d Compare April 26, 2026 01:51
@Vu-John Vu-John force-pushed the logging-inspector-route-conversions-wave-1 branch from f17abdd to 88ec9a6 Compare April 26, 2026 01:51
@Vu-John Vu-John temporarily deployed to preview-pr-1933 April 26, 2026 01:51 — with GitHub Actions Inactive
@Vu-John Vu-John force-pushed the logging-inspector-route-conversions-wave-2 branch from 9176f0d to cfcdbfc Compare April 26, 2026 02:18
@Vu-John Vu-John force-pushed the logging-inspector-route-conversions-wave-1 branch from 88ec9a6 to 96ee129 Compare April 26, 2026 02:18
@Vu-John Vu-John force-pushed the logging-inspector-route-conversions-wave-2 branch from cfcdbfc to e1a52f4 Compare April 26, 2026 02:22
@Vu-John Vu-John force-pushed the logging-inspector-route-conversions-wave-1 branch from 96ee129 to 0136f80 Compare April 26, 2026 02:22
@Vu-John Vu-John temporarily deployed to preview-pr-1933 April 26, 2026 02:22 — with GitHub Actions Inactive
@Vu-John Vu-John force-pushed the logging-inspector-route-conversions-wave-1 branch from 0136f80 to bf47dba Compare April 26, 2026 03:21
@Vu-John Vu-John force-pushed the logging-inspector-route-conversions-wave-2 branch from e1a52f4 to 5369c35 Compare April 26, 2026 03:21
@Vu-John Vu-John temporarily deployed to preview-pr-1933 April 26, 2026 03:21 — with GitHub Actions Inactive
@Vu-John Vu-John force-pushed the logging-inspector-route-conversions-wave-2 branch from 5369c35 to fe15c8a Compare April 26, 2026 03:28
@Vu-John Vu-John force-pushed the logging-inspector-route-conversions-wave-1 branch from bf47dba to 836264c Compare April 26, 2026 03:28
@Vu-John Vu-John temporarily deployed to preview-pr-1933 April 26, 2026 03:28 — with GitHub Actions Inactive
@Vu-John Vu-John force-pushed the logging-inspector-route-conversions-wave-1 branch from 836264c to d3e3d78 Compare April 26, 2026 03:43
@Vu-John Vu-John force-pushed the logging-inspector-route-conversions-wave-2 branch from fe15c8a to 3ceaa47 Compare April 26, 2026 03:43
@Vu-John Vu-John temporarily deployed to preview-pr-1933 April 26, 2026 03:43 — with GitHub Actions Inactive
@Vu-John Vu-John force-pushed the logging-inspector-route-conversions-wave-1 branch from d3e3d78 to d505dee Compare April 26, 2026 04:01
@Vu-John Vu-John force-pushed the logging-inspector-route-conversions-wave-2 branch from 3ceaa47 to 58d5256 Compare April 26, 2026 04:01
@Vu-John Vu-John force-pushed the logging-inspector-route-conversions-wave-2 branch from 58d5256 to fe228fc Compare April 26, 2026 04:11
@Vu-John Vu-John force-pushed the logging-inspector-route-conversions-wave-1 branch from d505dee to 3aa9855 Compare April 26, 2026 04:11
Base automatically changed from logging-inspector-route-conversions-wave-1 to main April 26, 2026 04:12
@dosubot dosubot Bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Apr 26, 2026
Adds mcp.tool.execution.failed to the event map and emits it from the
/execute callback catch. Converts web/oauth.ts proxy, metadata, and
debug/proxy routes to emit mcp.oauth.proxy.failed. resources.ts and
prompts.ts have no explicit error paths beyond withEphemeralConnection
delegation so are left unchanged.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@Vu-John Vu-John force-pushed the logging-inspector-route-conversions-wave-2 branch from fe228fc to a41775b Compare April 26, 2026 04:12
@dosubot dosubot Bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Apr 26, 2026
@Vu-John Vu-John merged commit 740089b into main Apr 26, 2026
8 of 11 checks passed
@Vu-John Vu-John deleted the logging-inspector-route-conversions-wave-2 branch April 26, 2026 04:13
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 26, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 7fb1cdc2-e70c-4a55-ba67-b656c1c301e5

📥 Commits

Reviewing files that changed from the base of the PR and between 5c65045 and a41775b.

📒 Files selected for processing (3)
  • mcpjam-inspector/server/routes/web/oauth.ts
  • mcpjam-inspector/server/routes/web/tools.ts
  • mcpjam-inspector/server/utils/log-events.ts

Walkthrough

The changes add structured error logging to three distinct failure points. OAuth proxy and metadata endpoints now emit categorized failure events containing the target hostname, phase indicator, and error classification. The tool execution endpoint adds similar logging when tool execution fails, capturing tool and server identifiers alongside error codes. A corresponding request event type is introduced to formalize the tool execution failure log schema.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants