Skip to content

type issues when building sdk#1908

Open
ignaciojimenezr wants to merge 1 commit intomainfrom
sdk-type
Open

type issues when building sdk#1908
ignaciojimenezr wants to merge 1 commit intomainfrom
sdk-type

Conversation

@ignaciojimenezr
Copy link
Copy Markdown
Collaborator

No description provided.

@chatgpt-codex-connector
Copy link
Copy Markdown

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Apr 23, 2026
@chelojimenez
Copy link
Copy Markdown
Contributor

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@dosubot dosubot Bot added the bug Something isn't working label Apr 23, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 23, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 7bb21463-053e-4c00-a4e2-1055c52a606a

📥 Commits

Reviewing files that changed from the base of the PR and between 8635c4d and 0b482eb.

📒 Files selected for processing (1)
  • sdk/src/oauth-login.ts

Walkthrough

The pull request refactors redirectUrl initialization in the OAuth login flow. Rather than declaring it as a mutable variable before interactive session creation, redirectUrl is now computed once as a constant, deriving from interactiveSession?.redirectUrl with fallbacks to config.redirectUrl and a default generator. Additionally, the OAuth HTTP requestExecutor callback's request parameter is explicitly typed as OAuthHttpRequest to align with the type passed to trackedRequest.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

Internal preview

Preview URL: https://mcp-inspector-pr-1908.up.railway.app
Deployed commit: cc69622
PR head commit: 0b482eb
Backend target: staging fallback.
Health: ❌ Convex unreachable — see upsert-preview job logs (staging may need convex deploy)
Access is employee-only in non-production environments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants