Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes Nightwatch support from Drainpipe v6, deleting associated documentation, scaffold files, the Composer plugin, and CI templates. Nightwatch tasks in drainpipe-dev/tasks/test.yml are replaced with deprecated no-ops. Original definitions of nightwatch:check and nightwatch:setup should be removed to avoid duplication.
deviantintegral
left a comment
deviantintegral
left a comment
There was a problem hiding this comment.
How do you want to handle deprecating this? We could do a last 4.x release that shows a warning (so folks can get other changes), and then do a 5.x release? Other ideas?
| # Restart is required to enable the provided Selenium containers | ||
| ddev restart | ||
|
|
||
| - name: Setup Selenium |
There was a problem hiding this comment.
It's possible folks are using Selenium containers but for non-nightwatch tests like DTT or Behat.
I still think we should remove them, but this is a broader change.
There was a problem hiding this comment.
The idea behind this "Setup Selenium" step in the test workflow is to be able to drop Nightwatch support while still using Selenium containers for DTT tests.
There was a problem hiding this comment.
I forget, is this optional? I think sites should only pull the selenium containers if they need them or opt into them.
There was a problem hiding this comment.
Actually, this TestPHPUnit.yml file is a workflow that runs for Drainpipe only - at this moment, DTT tests are not scaffolded to projects using Drainpipe in any case.
I like the idea of providing scaffold for DTT tests, tough. I will open a new ticket for this feature, if that sounds good.
There was a problem hiding this comment.
This is a pull request I implemented to make configuring DTT tests easier, which I think we can merge before this one as it is not directly related: #1198
|
I think we can deprecate Nightwatch in the next release (that would 5.1.x or 5.2.0), then we merge this one when publishing 6.0.0 - that way, everyone will be aware of the removal. |
rabbitlair
changed the title
2 participants
Closes #1173
Drops Nightwatch support, keeping the related tasks as no-op displaying a warning - this is to prevent users currently using Nightwatch from having errors.