Fixed reset not considering the message's argument #1110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
The bindings at https://github.com/LiveSplit/livesplit-core/blob/a135301b008d9211ae37ae14b4dc6cec5a3c2aaa/capi/src/web_command_sink.rs#L144 show that the option is passed to the TypeScript bindings, but LiveSplitOne didn't consider it. |
Contributor
Author
|
This is especially useful for autosplitters sending commands through the websocket, like the one I'm developing for Celeste, as they don't have to wait for player input between runs when resetting if the times have been beaten. |
Collaborator
|
Thanks :) |
CryZe
added
the
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this pull request, LiveSplitOne would not consider the server's "saveAttempt" argument when receiving a reset command. This makes sure the command is full taken into account, by asking the user if they wish to save the times if and only if the command has not provided the "saveAttempt" argument.