Preserve qBittorrent content path for imports#629
Conversation
|
The method is intended to "refresh" the knowledge Listenarr has about an ongoing download. Why would we want to add application data into the adapter reply ? If qBittorrent says there is no file, why do we want to assume otherwise ? I know the DownloadItem service is designed to already override some information into the adapter but I believe we should remove that and leave the DownloadClientGateway handle that if needed |
@T4g1 I agree. If this method is meant to refresh the import item from the client, then qBittorrent should remain the source of truth. Passing ClientContentPath from Download.Metadata into the adapter input lets stale Listenarr state override the current client response. @bigsaam Unfortunately I don't align with this PR’s approach. If qBittorrent returns no files/content path, we should surface that as an unresolved import state and retry later or block with a clear reason, rather than scanning a remembered path. |
therobbiedavis
left a comment
There was a problem hiding this comment.
@bigsaam I am going to close the PR. If you want to submit a PR that handles the underlying qBittorrent empty-files case separately by making it retryable or clearly blocked, while keeping the live client response as the source of truth, I would be receptive to that.
Thanks!
Summary
Tests