fix: Fix editable install: Inclulde packages for PEP660 (pip>=25)#137
Open
dasoumao wants to merge 1 commit intoLifelong-Robot-Learning:masterfrom
Open
fix: Fix editable install: Inclulde packages for PEP660 (pip>=25)#137dasoumao wants to merge 1 commit intoLifelong-Robot-Learning:masterfrom
dasoumao wants to merge 1 commit intoLifelong-Robot-Learning:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue where pip install -e LIBERO (editable install) dose not expose any importable Python packages under modern pip (PEP 517/660). As a result:
import liberofails with ModuleNotFoundError when execute outside the repository directory.This shows up reliably with recent pip (pip=25.3), which use PEP 660 editable installs and only maps packages explicitly discovered in the build configuration.
Root cause
The repo's top level
libero/directory is not a Python package (missing init.py file, also thelibero/lifelong/models/modules/), sosetuptools.find_packages()can fail to discover the expectedlibero.*packages depending on layout and tooling.Reproduction
Origin version:
After Fixed:
Note on prior work (duplicate PRs)
I realize similar changes were proposed before in #15 and #117 . This PR is a duplicate in terms of the mechanical changes, but I’m submitting it again because the reason has become more important recently: modern pip versions (pip >= 25.3) use PEP 660 editable installs, which are stricter than legacy setup.py develop behavior and therefore expose this packaging issue consistently.