Fix Patient Issues show Incorrect Dates When Left Blank#1572
Open
xurror wants to merge 1 commit intoLibreHealthIO:masterfrom
Open
Fix Patient Issues show Incorrect Dates When Left Blank#1572xurror wants to merge 1 commit intoLibreHealthIO:masterfrom
xurror wants to merge 1 commit intoLibreHealthIO:masterfrom
Conversation
Contributor
Author
|
@muarachmann and @mhn94 please can you review this? |
robbyoconnor
added
Feature: Patient Demographics
outreachy
muarachmann
approved these changes
Mar 20, 2020
Member
muarachmann
left a comment
muarachmann
left a comment
There was a problem hiding this comment.
LGTM! @mhn94 you've got this :)
muarachmann
requested changes
Mar 20, 2020
Member
muarachmann
left a comment
muarachmann
left a comment
There was a problem hiding this comment.
Okay @xurror I might have been in a haste as I didnt test this with some other dataset. Turns out that the dates are actually returned as 0000-00-00 when not stored.
Rather ensure a NULL is set in the database or do a check for this as it doesn't display the format correctly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1555