Added optional comment handling#504
Open
visorgames wants to merge 1 commit intoLeonidas-from-XIV:masterfrom
Open
Added optional comment handling#504visorgames wants to merge 1 commit intoLeonidas-from-XIV:masterfrom
visorgames wants to merge 1 commit intoLeonidas-from-XIV:masterfrom
Conversation
1 similar comment
|
+1 when will this be available please ? |
Owner
|
There is no plan for it at the moment.
|
|
How can we contribute to pull this through ? very helpful |
I found a library that is better adapted and also supports I have seen the information you left from many libraries, I believe you are also very anxious |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
XML-Comments can now be parsed or build.
The comments can be accessed via the commentskey (default:
$comments) under their parent node.To activate this feature, the option
parseCommentshas to be set totrue.To support multiple comments contained in the same tag, the comments are pushed to an array like any other node. Comments are only parsed if they are at least inside the root node.
The position of comments in the xml is only reliably preserved if they are not placed in between child tags with the same name (eg.:
<test>...</test><!-- comment --><test>...</test>) or are split by an other child tag (eg.:<!-- comment1 --><test/><!-- comment2 -->). Otherwise the original xml-structure can be rearranged, as nodes with the same tag-name get parsed into an array.This feature was already requested in the past: #44, #475