Open
Conversation
Create a sync version of parseString to API to permit
calling without a callback.
The current implemenation is sync due to underlying
implementation of SAX parser.
Examples:
```js
// Via root API
var result = xml2js.parseStringSync('< ... >', options)
// Via parser
var parser = new xml2js.Parser(options);
var result = parser.parseStringSync('< ... >');
```
See Leonidas-from-XIV#241 by @nobodyman
See Leonidas-from-XIV#319 by @mrparkers
fa6a733 to
c7df57c
Compare
1 similar comment
|
It would be nice if it could be merged |
|
👍 to this, there should be no I/O happening in a function called |
|
+1 |
|
any ideas when this can be merged? |
|
Please merge this.. |
|
lol why would this not be merged? |
|
For a function that is called Nevertheless, I hope that volunteers will get permission to continue maintenance. |
|
@Leonidas-from-XIV Plz merge this... I need sync function because I'm trying converting the parser to "sync" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Create a sync version of parseString to API to permit calling without a callback. The current implementation is sync due to underlying implementation of SAX parser.
This is a rebased version of #319 by @mrparkers which in turn was an add-on to #241 by @nobodyman. In addition to those changes, this PR:
Examples:
See #241 by @nobodyman
See #319 by @mrparkers